Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/chromeos/extensions/users_private/users_private_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/users_private/users_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
index ca37053f6faa182f221251ec413e93f7598405ec..4026e98cdd6cec2e7c2148d92b4fc530b5695973 100644
--- a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
+++ b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
@@ -85,8 +85,8 @@ UsersPrivateGetWhitelistedUsersFunction::Run() {
user_manager::UserManager* user_manager = user_manager::UserManager::Get();
const user_manager::UserList& users = user_manager->GetUsers();
for (const auto* user : users) {
- email_list->AppendIfNotPresent(base::MakeUnique<base::StringValue>(
- user->GetAccountId().GetUserEmail()));
+ email_list->AppendIfNotPresent(
+ base::MakeUnique<base::Value>(user->GetAccountId().GetUserEmail()));
}
if (chromeos::OwnerSettingsServiceChromeOS* service =
@@ -137,7 +137,7 @@ UsersPrivateAddWhitelistedUserFunction::Run() {
return RespondNow(OneArgument(base::MakeUnique<base::Value>(false)));
}
- base::StringValue username_value(username);
+ base::Value username_value(username);
UsersPrivateDelegate* delegate =
UsersPrivateDelegateFactory::GetForBrowserContext(browser_context());
@@ -171,7 +171,7 @@ UsersPrivateRemoveWhitelistedUserFunction::Run() {
return RespondNow(OneArgument(base::MakeUnique<base::Value>(false)));
}
- base::StringValue canonical_email(gaia::CanonicalizeEmail(parameters->email));
+ base::Value canonical_email(gaia::CanonicalizeEmail(parameters->email));
UsersPrivateDelegate* delegate =
UsersPrivateDelegateFactory::GetForBrowserContext(browser_context());
« no previous file with comments | « chrome/browser/chromeos/extensions/input_method_api.cc ('k') | chrome/browser/chromeos/file_manager/file_tasks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698