components/prefs/testing_pref_store.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/prefs/testing_pref_store.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/prefs/testing_pref_store.cc

diff --git a/components/prefs/testing_pref_store.cc b/components/prefs/testing_pref_store.cc

index 8f6f2098d470ff4802f56879f0fc7fbd34ffa7ea..e9b04c8e54fb3b3be5fba825b23f46aa8491cefd 100644

--- a/components/prefs/testing_pref_store.cc

+++ b/components/prefs/testing_pref_store.cc

@@ -124,8 +124,7 @@ void TestingPrefStore::ReportValueChanged(const std::string& key,

void TestingPrefStore::SetString(const std::string& key,

const std::string& value) {

- SetValue(key, base::MakeUnique<base::StringValue>(value),

- DEFAULT_PREF_WRITE_FLAGS);

+ SetValue(key, base::MakeUnique<base::Value>(value), DEFAULT_PREF_WRITE_FLAGS);

}

void TestingPrefStore::SetInteger(const std::string& key, int value) {