extensions/browser/api/system_storage/system_storage_api.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_storage/system_storage_api.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/system_storage/system_storage_api.cc

diff --git a/extensions/browser/api/system_storage/system_storage_api.cc b/extensions/browser/api/system_storage/system_storage_api.cc

index 3bd5ecfa68521df078c83e9011bc3a4523291c69..ebc0ae56915d19c74fe019d1ac8ce431397c7b9d 100644

--- a/extensions/browser/api/system_storage/system_storage_api.cc

+++ b/extensions/browser/api/system_storage/system_storage_api.cc

@@ -89,8 +89,8 @@ void SystemStorageEjectDeviceFunction::HandleResponse(

result = api::system_storage::EJECT_DEVICE_RESULT_CODE_FAILURE;

}

- Respond(OneArgument(base::MakeUnique<base::StringValue>(

- api::system_storage::ToString(result))));

+ Respond(OneArgument(

+ base::MakeUnique<base::Value>(api::system_storage::ToString(result))));

}

SystemStorageGetAvailableCapacityFunction::