chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/file_tasks.cc ('k') | chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

index 7ef9e419c1d348dfa061658c4f04da88fb912618..4578cc69601cadaa57a44979966173605dd3ac46 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

@@ -175,7 +175,7 @@ TEST_F(FileSystemProviderOperationsReadFileTest, OnSuccess) {

const int execution_time = 0;

base::ListValue value_as_list;

- value_as_list.Set(0, new base::StringValue(kFileSystemId));

+ value_as_list.Set(0, new base::Value(kFileSystemId));

value_as_list.Set(1, new base::Value(kRequestId));

value_as_list.Set(

2, base::BinaryValue::CreateWithCopiedBuffer(data.c_str(), data.size()));