Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/extensions/chrome_app_sorting.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
index c74a5711c5c1e8212fffd7800a175f5800d6c1ef..044a7e5f7fd8ecc0558a2b80eece3d274ff1a3e8 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
@@ -68,7 +68,6 @@ namespace web_request = extensions::api::web_request;
using base::BinaryValue;
using base::DictionaryValue;
using base::ListValue;
-using base::StringValue;
using base::Time;
using base::TimeDelta;
using base::Value;
@@ -609,7 +608,7 @@ TEST_F(ExtensionWebRequestTest, AccessRequestBodyData) {
&raw);
extensions::subtle::AppendKeyValuePair(
keys::kRequestBodyRawFileKey,
- base::MakeUnique<base::StringValue>(std::string()), &raw);
+ base::MakeUnique<base::Value>(std::string()), &raw);
extensions::subtle::AppendKeyValuePair(
keys::kRequestBodyRawBytesKey,
BinaryValue::CreateWithCopiedBuffer(kPlainBlock2, kPlainBlock2Length),
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/extensions/chrome_app_sorting.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698