chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/settings/scoped_cros_settings_test_helper.cc ('k') | chrome/browser/chromeos/settings/system_settings_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc

diff --git a/chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc b/chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc

index 1a6b4a6f89ab09db99caed2540cff3659d0a0fb6..829dbe9c9c224bdc8cecdc89c3f5af597ad73983 100644

--- a/chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc

+++ b/chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc

@@ -73,7 +73,7 @@ TEST_F(StubCrosSettingsProviderTest, Defaults) {

TEST_F(StubCrosSettingsProviderTest, Set) {

// Setting value and reading it afterwards returns the same value.

- base::StringValue owner_value("me@owner");

+ base::Value owner_value("me@owner");

provider_->Set(kDeviceOwner, owner_value);

AssertPref(kDeviceOwner, &owner_value);

ExpectObservers(kDeviceOwner, 1);

@@ -81,7 +81,7 @@ TEST_F(StubCrosSettingsProviderTest, Set) {

TEST_F(StubCrosSettingsProviderTest, SetMissing) {

// Setting is missing initially but is added by |Set|.

- base::StringValue pref_value("testing");

+ base::Value pref_value("testing");

ASSERT_FALSE(provider_->Get(kReleaseChannel));

provider_->Set(kReleaseChannel, pref_value);

AssertPref(kReleaseChannel, &pref_value);