components/plugins/renderer/loadable_plugin_placeholder.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/plugins/renderer/loadable_plugin_placeholder.cc

diff --git a/components/plugins/renderer/loadable_plugin_placeholder.cc b/components/plugins/renderer/loadable_plugin_placeholder.cc

index 8bffae8705f710771a838e011580c2cc4896ff16..355dc7d6db392b4397b4218f32c40be11647d42e 100644

--- a/components/plugins/renderer/loadable_plugin_placeholder.cc

+++ b/components/plugins/renderer/loadable_plugin_placeholder.cc

@@ -338,7 +338,7 @@ void LoadablePluginPlaceholder::DidFinishIconRepositionForTestingCallback() {

std::unique_ptr<content::V8ValueConverter> converter(

content::V8ValueConverter::create());

- base::StringValue value("placeholderReady");

+ base::Value value("placeholderReady");

blink::WebSerializedScriptValue message_data =

blink::WebSerializedScriptValue::serialize(converter->ToV8Value(

&value, element.document().frame()->mainWorldScriptContext()));