extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc ('k') | extensions/browser/api/guest_view/web_view/web_view_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

index 1dfaac96854b567a16e3fb72a485c85dd8737448..0ef967fed8b82112462042ebdd1c46a56a6f0935 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

@@ -27,7 +27,6 @@

using base::DictionaryValue;

using base::ListValue;

-using base::StringValue;

using base::Value;

namespace extensions {

@@ -49,7 +48,7 @@ TEST(WebRequestConditionAttributeTest, CreateConditionAttribute) {

std::string error;

scoped_refptr<const WebRequestConditionAttribute> result;

- base::StringValue string_value("main_frame");

+ base::Value string_value("main_frame");

base::ListValue resource_types;

resource_types.AppendString("main_frame");