chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

index 26c0a3f548cc7b0cb999ced47fcd87a5384a8abb..d47d2825f55690452f5011e66616bbc32484cbe7 100644

--- a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

@@ -380,7 +380,7 @@ void KeyboardOverlayHandler::GetInputMethodId(const base::ListValue* args) {

chromeos::input_method::InputMethodManager::Get();

const chromeos::input_method::InputMethodDescriptor& descriptor =

manager->GetActiveIMEState()->GetCurrentInputMethod();

- base::StringValue param(descriptor.id());

+ base::Value param(descriptor.id());

web_ui()->CallJavascriptFunctionUnsafe("initKeyboardOverlayId", param);

}