components/ssl_config/ssl_config_service_manager_pref_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ssl_config/ssl_config_service_manager_pref_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ssl_config/ssl_config_service_manager_pref_unittest.cc

diff --git a/components/ssl_config/ssl_config_service_manager_pref_unittest.cc b/components/ssl_config/ssl_config_service_manager_pref_unittest.cc

index 12edb50c937f502358b3a1b85d56a7cf34cf080f..87988a1270c25b19a9d6ce6e3b5a6892159a2d0a 100644

--- a/components/ssl_config/ssl_config_service_manager_pref_unittest.cc

+++ b/components/ssl_config/ssl_config_service_manager_pref_unittest.cc

@@ -163,7 +163,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, NoSSL3) {

TestingPrefServiceSimple local_state;

local_state.SetUserPref(ssl_config::prefs::kSSLVersionMin,

- new base::StringValue("ssl3"));

+ new base::Value("ssl3"));

SSLConfigServiceManager::RegisterPrefs(local_state.registry());

std::unique_ptr<SSLConfigServiceManager> config_manager(

@@ -185,7 +185,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, SSLVersionMax) {

TestingPrefServiceSimple local_state;

local_state.SetUserPref(ssl_config::prefs::kSSLVersionMax,

- new base::StringValue("tls1.3"));

+ new base::Value("tls1.3"));

SSLConfigServiceManager::RegisterPrefs(local_state.registry());

std::unique_ptr<SSLConfigServiceManager> config_manager(

@@ -206,7 +206,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, NoTLS11Max) {

TestingPrefServiceSimple local_state;

local_state.SetUserPref(ssl_config::prefs::kSSLVersionMax,

- new base::StringValue("tls1.1"));

+ new base::Value("tls1.1"));

SSLConfigServiceManager::RegisterPrefs(local_state.registry());

std::unique_ptr<SSLConfigServiceManager> config_manager(

@@ -252,7 +252,7 @@ TEST_F(SSLConfigServiceManagerPrefTest, TLS13SSLVersionMax) {

TestingPrefServiceSimple local_state;

local_state.SetUserPref(ssl_config::prefs::kSSLVersionMax,

- new base::StringValue("tls1.2"));

+ new base::Value("tls1.2"));

SSLConfigServiceManager::RegisterPrefs(local_state.registry());

std::unique_ptr<SSLConfigServiceManager> config_manager(