chrome/browser/ui/webui/sync_internals_message_handler.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_internals_message_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc ('k') | chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/sync_internals_message_handler.cc

diff --git a/chrome/browser/ui/webui/sync_internals_message_handler.cc b/chrome/browser/ui/webui/sync_internals_message_handler.cc

index 4a5a532cd9b866a1a464b003ec78a9a3d6d0ddbd..eab283ce9c0900b839ff0dc880bc56ffa0c1c0f0 100644

--- a/chrome/browser/ui/webui/sync_internals_message_handler.cc

+++ b/chrome/browser/ui/webui/sync_internals_message_handler.cc

@@ -147,8 +147,7 @@ void SyncInternalsMessageHandler::HandleRequestListOfTypes(

event_details.Set(syncer::sync_ui_util::kTypes, type_list.release());

web_ui()->CallJavascriptFunctionUnsafe(

syncer::sync_ui_util::kDispatchEvent,

- base::StringValue(syncer::sync_ui_util::kOnReceivedListOfTypes),

- event_details);

+ base::Value(syncer::sync_ui_util::kOnReceivedListOfTypes), event_details);

}

void SyncInternalsMessageHandler::HandleGetAllNodes(

@@ -184,7 +183,7 @@ void SyncInternalsMessageHandler::OnProtocolEvent(

syncer::ProtocolEvent::ToValue(event));

web_ui()->CallJavascriptFunctionUnsafe(

syncer::sync_ui_util::kDispatchEvent,

- base::StringValue(syncer::sync_ui_util::kOnProtocolEvent), *value);

+ base::Value(syncer::sync_ui_util::kOnProtocolEvent), *value);

}

void SyncInternalsMessageHandler::OnCommitCountersUpdated(

@@ -215,7 +214,7 @@ void SyncInternalsMessageHandler::EmitCounterUpdate(

details->Set(syncer::sync_ui_util::kCounters, value.release());

web_ui()->CallJavascriptFunctionUnsafe(

syncer::sync_ui_util::kDispatchEvent,

- base::StringValue(syncer::sync_ui_util::kOnCountersUpdated), *details);

+ base::Value(syncer::sync_ui_util::kOnCountersUpdated), *details);

}

void SyncInternalsMessageHandler::HandleJsEvent(

@@ -224,8 +223,7 @@ void SyncInternalsMessageHandler::HandleJsEvent(

DVLOG(1) << "Handling event: " << name

<< " with details " << details.ToString();

web_ui()->CallJavascriptFunctionUnsafe(syncer::sync_ui_util::kDispatchEvent,

- base::StringValue(name),

- details.Get());

+ base::Value(name), details.Get());

}

void SyncInternalsMessageHandler::SendAboutInfo() {

@@ -236,7 +234,7 @@ void SyncInternalsMessageHandler::SendAboutInfo() {

signin);

web_ui()->CallJavascriptFunctionUnsafe(

syncer::sync_ui_util::kDispatchEvent,

- base::StringValue(syncer::sync_ui_util::kOnAboutInfoUpdated), *value);

+ base::Value(syncer::sync_ui_util::kOnAboutInfoUpdated), *value);

}

// Gets the ProfileSyncService of the underlying original profile.