extensions/browser/api/vpn_provider/vpn_provider_api.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/vpn_provider/vpn_provider_api.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/vpn_provider/vpn_provider_api.cc

diff --git a/extensions/browser/api/vpn_provider/vpn_provider_api.cc b/extensions/browser/api/vpn_provider/vpn_provider_api.cc

index 5f58f3214c8a2455e6f685d683339eeed4be6354..27d9c02cf9fab9ac9f00b87e352b3669802807d8 100644

--- a/extensions/browser/api/vpn_provider/vpn_provider_api.cc

+++ b/extensions/browser/api/vpn_provider/vpn_provider_api.cc

@@ -163,7 +163,7 @@ void VpnThreadExtensionFunction::SignalCallCompletionSuccess() {

void VpnThreadExtensionFunction::SignalCallCompletionSuccessWithId(

const std::string& configuration_id) {

- Respond(OneArgument(base::MakeUnique<base::StringValue>(configuration_id)));

+ Respond(OneArgument(base::MakeUnique<base::Value>(configuration_id)));

}

void VpnThreadExtensionFunction::SignalCallCompletionSuccessWithWarning(