Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/media_router/media_router_webui_message_handle r.h" 5 #include "chrome/browser/ui/webui/media_router/media_router_webui_message_handle r.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 void MediaRouterWebUIMessageHandler::OnCreateRouteResponseReceived( 275 void MediaRouterWebUIMessageHandler::OnCreateRouteResponseReceived(
276 const MediaSink::Id& sink_id, 276 const MediaSink::Id& sink_id,
277 const MediaRoute* route) { 277 const MediaRoute* route) {
278 DVLOG(2) << "OnCreateRouteResponseReceived"; 278 DVLOG(2) << "OnCreateRouteResponseReceived";
279 if (route) { 279 if (route) {
280 int current_cast_mode = CurrentCastModeForRouteId( 280 int current_cast_mode = CurrentCastModeForRouteId(
281 route->media_route_id(), media_router_ui_->routes_and_cast_modes()); 281 route->media_route_id(), media_router_ui_->routes_and_cast_modes());
282 std::unique_ptr<base::DictionaryValue> route_value(RouteToValue( 282 std::unique_ptr<base::DictionaryValue> route_value(RouteToValue(
283 *route, false, media_router_ui_->GetRouteProviderExtensionId(), 283 *route, false, media_router_ui_->GetRouteProviderExtensionId(),
284 incognito_, current_cast_mode)); 284 incognito_, current_cast_mode));
285 web_ui()->CallJavascriptFunctionUnsafe( 285 web_ui()->CallJavascriptFunctionUnsafe(kOnCreateRouteResponseReceived,
286 kOnCreateRouteResponseReceived, base::StringValue(sink_id), 286 base::Value(sink_id), *route_value,
287 *route_value, base::Value(route->for_display())); 287 base::Value(route->for_display()));
288 } else { 288 } else {
289 web_ui()->CallJavascriptFunctionUnsafe( 289 web_ui()->CallJavascriptFunctionUnsafe(
290 kOnCreateRouteResponseReceived, base::StringValue(sink_id), 290 kOnCreateRouteResponseReceived, base::Value(sink_id),
291 *base::Value::CreateNullValue(), base::Value(false)); 291 *base::Value::CreateNullValue(), base::Value(false));
292 } 292 }
293 } 293 }
294 294
295 void MediaRouterWebUIMessageHandler::ReturnSearchResult( 295 void MediaRouterWebUIMessageHandler::ReturnSearchResult(
296 const std::string& sink_id) { 296 const std::string& sink_id) {
297 DVLOG(2) << "ReturnSearchResult"; 297 DVLOG(2) << "ReturnSearchResult";
298 web_ui()->CallJavascriptFunctionUnsafe(kReceiveSearchResult, 298 web_ui()->CallJavascriptFunctionUnsafe(kReceiveSearchResult,
299 base::StringValue(sink_id)); 299 base::Value(sink_id));
300 } 300 }
301 301
302 void MediaRouterWebUIMessageHandler::UpdateIssue(const Issue& issue) { 302 void MediaRouterWebUIMessageHandler::UpdateIssue(const Issue& issue) {
303 DVLOG(2) << "UpdateIssue"; 303 DVLOG(2) << "UpdateIssue";
304 web_ui()->CallJavascriptFunctionUnsafe(kSetIssue, *IssueToValue(issue)); 304 web_ui()->CallJavascriptFunctionUnsafe(kSetIssue, *IssueToValue(issue));
305 } 305 }
306 306
307 void MediaRouterWebUIMessageHandler::ClearIssue() { 307 void MediaRouterWebUIMessageHandler::ClearIssue() {
308 DVLOG(2) << "ClearIssue"; 308 DVLOG(2) << "ClearIssue";
309 web_ui()->CallJavascriptFunctionUnsafe(kSetIssue, 309 web_ui()->CallJavascriptFunctionUnsafe(kSetIssue,
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
895 } 895 }
896 896
897 return value; 897 return value;
898 } 898 }
899 899
900 void MediaRouterWebUIMessageHandler::SetWebUIForTest(content::WebUI* web_ui) { 900 void MediaRouterWebUIMessageHandler::SetWebUIForTest(content::WebUI* web_ui) {
901 set_web_ui(web_ui); 901 set_web_ui(web_ui);
902 } 902 }
903 903
904 } // namespace media_router 904 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698