Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: extensions/browser/api/storage/storage_frontend_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/storage/storage_frontend_unittest.cc
diff --git a/extensions/browser/api/storage/storage_frontend_unittest.cc b/extensions/browser/api/storage/storage_frontend_unittest.cc
index 6f37a2e11d1fb97e07c1571ab6496736fef6ab12..91733d6b3be99854da485ba376e362f2814a2542 100644
--- a/extensions/browser/api/storage/storage_frontend_unittest.cc
+++ b/extensions/browser/api/storage/storage_frontend_unittest.cc
@@ -103,7 +103,7 @@ TEST_F(ExtensionSettingsFrontendTest, SettingsPreservedAcrossReconstruction) {
// The correctness of Get/Set/Remove/Clear is tested elsewhere so no need to
// be too rigorous.
{
- base::StringValue bar("bar");
+ base::Value bar("bar");
ValueStore::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
ASSERT_TRUE(result->status().ok());
}
@@ -133,7 +133,7 @@ TEST_F(ExtensionSettingsFrontendTest, SettingsClearedOnUninstall) {
util::GetStorage(extension, settings::LOCAL, frontend_.get());
{
- base::StringValue bar("bar");
+ base::Value bar("bar");
ValueStore::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
ASSERT_TRUE(result->status().ok());
}
@@ -160,7 +160,7 @@ TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {
util::GetStorage(extension, settings::LOCAL, frontend_.get());
{
- base::StringValue bar("bar");
+ base::Value bar("bar");
ValueStore::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
ASSERT_TRUE(result->status().ok());
EXPECT_TRUE(base::PathExists(temp_dir_.GetPath()));
« no previous file with comments | « extensions/browser/api/storage/settings_test_util.cc ('k') | extensions/browser/api/system_storage/system_storage_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698