Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: extensions/renderer/argument_spec.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/argument_spec.cc
diff --git a/extensions/renderer/argument_spec.cc b/extensions/renderer/argument_spec.cc
index c71e0e70b7f347d24561b13493d04f4ba98c19d5..c46d320649a4ede808a0c2a29935226a4cf43bc1 100644
--- a/extensions/renderer/argument_spec.cc
+++ b/extensions/renderer/argument_spec.cc
@@ -228,9 +228,9 @@ bool ArgumentSpec::ParseArgumentToFundamental(
if (!enum_values_.empty() && enum_values_.count(s) == 0)
return false;
if (out_value) {
- // TODO(devlin): If base::StringValue ever takes a std::string&&, we
+ // TODO(devlin): If base::Value ever takes a std::string&&, we
// could use std::move to construct.
- *out_value = base::MakeUnique<base::StringValue>(s);
+ *out_value = base::MakeUnique<base::Value>(s);
}
return true;
}
« no previous file with comments | « extensions/renderer/activity_log_converter_strategy.cc ('k') | extensions/shell/browser/api/identity/identity_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698