chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

index 57bd3f0fa65e388481e77c10dc6211bf1301e35a..34527db3a823d17ddf6869e6a3b07b345841396a 100644

--- a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

@@ -292,7 +292,7 @@ void InlineLoginUIBrowserTest::AddEmailToOneClickRejectedList(

PrefService* pref_service = browser()->profile()->GetPrefs();

ListPrefUpdate updater(pref_service,

prefs::kReverseAutologinRejectedEmailList);

- updater->AppendIfNotPresent(base::MakeUnique<base::StringValue>(email));

+ updater->AppendIfNotPresent(base::MakeUnique<base::Value>(email));

}

void InlineLoginUIBrowserTest::AllowSigninCookies(bool enable) {