Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: components/sync/syncable/entry_kernel.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/protocol/proto_value_conversions.cc ('k') | components/sync/syncable/model_type.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/syncable/entry_kernel.cc
diff --git a/components/sync/syncable/entry_kernel.cc b/components/sync/syncable/entry_kernel.cc
index 20cb7b4a3dfb19d33c2f2f8be88aad313002461d..591ef927065b2ff68a849edabda2fb7c2c6992f6 100644
--- a/components/sync/syncable/entry_kernel.cc
+++ b/components/sync/syncable/entry_kernel.cc
@@ -121,15 +121,15 @@ void SetEncryptableProtoValues(const EntryKernel& kernel,
// Helper functions for SetFieldValues().
-base::StringValue* Int64ToValue(int64_t i) {
- return new base::StringValue(base::Int64ToString(i));
+base::Value* Int64ToValue(int64_t i) {
+ return new base::Value(base::Int64ToString(i));
}
-base::StringValue* TimeToValue(const base::Time& t) {
- return new base::StringValue(GetTimeDebugString(t));
+base::Value* TimeToValue(const base::Time& t) {
+ return new base::Value(GetTimeDebugString(t));
}
-base::StringValue* IdToValue(const Id& id) {
+base::Value* IdToValue(const Id& id) {
return id.ToValue();
}
@@ -137,17 +137,16 @@ base::Value* BooleanToValue(bool bool_val) {
return new base::Value(bool_val);
}
-base::StringValue* StringToValue(const std::string& str) {
- return new base::StringValue(str);
+base::Value* StringToValue(const std::string& str) {
+ return new base::Value(str);
}
-base::StringValue* UniquePositionToValue(const UniquePosition& pos) {
- return new base::StringValue(pos.ToDebugString());
+base::Value* UniquePositionToValue(const UniquePosition& pos) {
+ return new base::Value(pos.ToDebugString());
}
-base::StringValue* AttachmentMetadataToValue(
- const sync_pb::AttachmentMetadata& a) {
- return new base::StringValue(a.SerializeAsString());
+base::Value* AttachmentMetadataToValue(const sync_pb::AttachmentMetadata& a) {
+ return new base::Value(a.SerializeAsString());
}
} // namespace
« no previous file with comments | « components/sync/protocol/proto_value_conversions.cc ('k') | components/sync/syncable/model_type.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698