Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: chromeos/network/network_cert_migrator_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_cert_migrator_unittest.cc
diff --git a/chromeos/network/network_cert_migrator_unittest.cc b/chromeos/network/network_cert_migrator_unittest.cc
index 006027b0004ff5682ca0b4149846d63a28001d24..d57a4aed1c7cbaf745872d4a3903f4155a362b52 100644
--- a/chromeos/network/network_cert_migrator_unittest.cc
+++ b/chromeos/network/network_cert_migrator_unittest.cc
@@ -107,24 +107,22 @@ class NetworkCertMigratorTest : public testing::Test {
// Ensure that the service appears as 'configured', i.e. is associated to a
// Shill profile.
- service_test_->SetServiceProperty(
- network_id, shill::kProfileProperty, base::StringValue(kProfile));
+ service_test_->SetServiceProperty(network_id, shill::kProfileProperty,
+ base::Value(kProfile));
}
void SetupNetworkWithEapCertId(bool wifi, const std::string& cert_id) {
std::string type = wifi ? shill::kTypeWifi: shill::kTypeEthernetEap;
std::string name = wifi ? kWifiStub : kEthernetEapStub;
AddService(name, type, shill::kStateOnline);
- service_test_->SetServiceProperty(
- name, shill::kEapCertIdProperty, base::StringValue(cert_id));
- service_test_->SetServiceProperty(
- name, shill::kEapKeyIdProperty, base::StringValue(cert_id));
+ service_test_->SetServiceProperty(name, shill::kEapCertIdProperty,
+ base::Value(cert_id));
+ service_test_->SetServiceProperty(name, shill::kEapKeyIdProperty,
+ base::Value(cert_id));
if (wifi) {
- service_test_->SetServiceProperty(
- name,
- shill::kSecurityClassProperty,
- base::StringValue(shill::kSecurity8021x));
+ service_test_->SetServiceProperty(name, shill::kSecurityClassProperty,
+ base::Value(shill::kSecurity8021x));
}
}
« no previous file with comments | « chromeos/network/host_resolver_impl_chromeos_unittest.cc ('k') | chromeos/network/network_configuration_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698