Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2104)

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_prefs.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
diff --git a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
index e420cdc96f2a6fb25504622ffff2864df66b5d71..1d486538241f036de52851293b7db061fb9c6852 100644
--- a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
@@ -49,15 +49,13 @@ void JavaScriptDialogHelper::RunJavaScriptDialog(
const DialogClosedCallback& callback,
bool* did_suppress_message) {
base::DictionaryValue request_info;
- request_info.Set(
- webview::kDefaultPromptText,
- new base::StringValue(base::UTF16ToUTF8(default_prompt_text)));
+ request_info.Set(webview::kDefaultPromptText,
+ new base::Value(base::UTF16ToUTF8(default_prompt_text)));
request_info.Set(webview::kMessageText,
- new base::StringValue(base::UTF16ToUTF8(message_text)));
- request_info.Set(
- webview::kMessageType,
- new base::StringValue(JavaScriptDialogTypeToString(dialog_type)));
- request_info.Set(guest_view::kUrl, new base::StringValue(origin_url.spec()));
+ new base::Value(base::UTF16ToUTF8(message_text)));
+ request_info.Set(webview::kMessageType,
+ new base::Value(JavaScriptDialogTypeToString(dialog_type)));
+ request_info.Set(guest_view::kUrl, new base::Value(origin_url.spec()));
WebViewPermissionHelper* web_view_permission_helper =
WebViewPermissionHelper::FromWebContents(web_contents);
web_view_permission_helper->RequestPermission(
« no previous file with comments | « extensions/browser/extension_prefs.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698