Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/user_prefs/tracked/pref_hash_filter_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_prefs/tracked/pref_hash_filter_unittest.cc
diff --git a/components/user_prefs/tracked/pref_hash_filter_unittest.cc b/components/user_prefs/tracked/pref_hash_filter_unittest.cc
index 42ea4f5092a70a5f75140b5f3b80dacccab6313c..7670407d47ac0de743b3dd110f24698eb85503ed 100644
--- a/components/user_prefs/tracked/pref_hash_filter_unittest.cc
+++ b/components/user_prefs/tracked/pref_hash_filter_unittest.cc
@@ -463,7 +463,7 @@ class MockHashStoreContents : public HashStoreContents {
std::string MockHashStoreContents::GetStoredMac(const std::string& path) const {
const base::Value* out_value;
if (dictionary_.GetWithoutPathExpansion(path, &out_value)) {
- const base::StringValue* value_as_string;
+ const base::Value* value_as_string;
EXPECT_TRUE(out_value->GetAsString(&value_as_string));
return value_as_string->GetString();
@@ -481,7 +481,7 @@ std::string MockHashStoreContents::GetStoredSplitMac(
EXPECT_TRUE(out_value->GetAsDictionary(&value_as_dict));
if (value_as_dict->GetWithoutPathExpansion(split_path, &out_value)) {
- const base::StringValue* value_as_string;
+ const base::Value* value_as_string;
EXPECT_TRUE(out_value->GetAsString(&value_as_string));
return value_as_string->GetString();
@@ -703,7 +703,7 @@ TEST_P(PrefHashFilterTest, StampSuperMACAltersStore) {
TEST_P(PrefHashFilterTest, FilterTrackedPrefUpdate) {
base::DictionaryValue root_dict;
// Ownership of |string_value| is transfered to |root_dict|.
- base::Value* string_value = new base::StringValue("string value");
+ base::Value* string_value = new base::Value("string value");
root_dict.Set(kAtomicPref, string_value);
// No path should be stored on FilterUpdate.
@@ -784,7 +784,7 @@ TEST_P(PrefHashFilterTest, FilterSplitPrefUpdate) {
TEST_P(PrefHashFilterTest, FilterUntrackedPrefUpdate) {
base::DictionaryValue root_dict;
- root_dict.Set("untracked", new base::StringValue("some value"));
+ root_dict.Set("untracked", new base::Value("some value"));
pref_hash_filter_->FilterUpdate("untracked");
// No paths should be stored on FilterUpdate.
@@ -896,7 +896,7 @@ TEST_P(PrefHashFilterTest, UnknownNullValue) {
TEST_P(PrefHashFilterTest, InitialValueUnknown) {
// Ownership of these values is transfered to |pref_store_contents_|.
- base::StringValue* string_value = new base::StringValue("string value");
+ base::Value* string_value = new base::Value("string value");
pref_store_contents_->Set(kAtomicPref, string_value);
base::DictionaryValue* dict_value = new base::DictionaryValue;
@@ -963,7 +963,7 @@ TEST_P(PrefHashFilterTest, InitialValueUnknown) {
TEST_P(PrefHashFilterTest, InitialValueTrustedUnknown) {
// Ownership of this value is transfered to |pref_store_contents_|.
- base::Value* string_value = new base::StringValue("test");
+ base::Value* string_value = new base::Value("test");
pref_store_contents_->Set(kAtomicPref, string_value);
base::DictionaryValue* dict_value = new base::DictionaryValue;
@@ -1130,7 +1130,7 @@ TEST_P(PrefHashFilterTest, EmptyCleared) {
TEST_P(PrefHashFilterTest, InitialValueUnchangedLegacyId) {
// Ownership of these values is transfered to |pref_store_contents_|.
- base::StringValue* string_value = new base::StringValue("string value");
+ base::Value* string_value = new base::Value("string value");
pref_store_contents_->Set(kAtomicPref, string_value);
base::DictionaryValue* dict_value = new base::DictionaryValue;
« no previous file with comments | « components/user_prefs/tracked/pref_hash_filter.cc ('k') | components/user_prefs/tracked/pref_hash_store_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698