Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5335)

Unified Diff: chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc b/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
index 6a00c7c38215f08076b8bd6bf83333c982e3294f..999d4f8e2cdd5a26f64f1329196c8a44bd13c08e 100644
--- a/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
@@ -92,7 +92,7 @@ void ManageProfileHandler::OnProfileAvatarChanged(
const base::FilePath& profile_path) {
// This is necessary to send the potentially updated GAIA photo.
CallJavascriptFunction("cr.webUIListenerCallback",
- base::StringValue("available-icons-changed"),
+ base::Value("available-icons-changed"),
*GetAvailableIcons());
}
@@ -194,8 +194,8 @@ void ManageProfileHandler::HandleRequestProfileShortcutStatus(
ProfileAttributesStorage& storage =
g_browser_process->profile_manager()->GetProfileAttributesStorage();
if (storage.GetNumberOfProfiles() <= 1u) {
- ResolveJavascriptCallback(base::StringValue(callback_id),
- base::StringValue(kProfileShortcutSettingHidden));
+ ResolveJavascriptCallback(base::Value(callback_id),
+ base::Value(kProfileShortcutSettingHidden));
return;
}
@@ -212,9 +212,9 @@ void ManageProfileHandler::OnHasProfileShortcuts(
const std::string& callback_id, bool has_shortcuts) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
ResolveJavascriptCallback(
- base::StringValue(callback_id),
- base::StringValue(has_shortcuts ? kProfileShortcutFound
- : kProfileShortcutNotFound));
+ base::Value(callback_id),
+ base::Value(has_shortcuts ? kProfileShortcutFound
+ : kProfileShortcutNotFound));
}
void ManageProfileHandler::HandleAddProfileShortcut(

Powered by Google App Engine
This is Rietveld 408576698