Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: chrome/browser/download/download_query_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_query_unittest.cc
diff --git a/chrome/browser/download/download_query_unittest.cc b/chrome/browser/download/download_query_unittest.cc
index 84995e1dc0e5e6599097e5b248dd1c17a63ca064..9c0a1821c36f208f48caf612169baea685375539 100644
--- a/chrome/browser/download/download_query_unittest.cc
+++ b/chrome/browser/download/download_query_unittest.cc
@@ -128,17 +128,17 @@ void DownloadQueryTest::AddFilter(DownloadQuery::FilterType name,
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, const char* cpp_value) {
- CHECK(query_.AddFilter(name, base::StringValue(cpp_value)));
+ CHECK(query_.AddFilter(name, base::Value(cpp_value)));
}
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, std::string cpp_value) {
- CHECK(query_.AddFilter(name, base::StringValue(cpp_value)));
+ CHECK(query_.AddFilter(name, base::Value(cpp_value)));
}
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, const base::char16* cpp_value) {
- CHECK(query_.AddFilter(name, base::StringValue(cpp_value)));
+ CHECK(query_.AddFilter(name, base::Value(cpp_value)));
}
template<> void DownloadQueryTest::AddFilter(
@@ -164,7 +164,7 @@ template<> void DownloadQueryTest::AddFilter(
#if defined(OS_WIN)
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, std::wstring cpp_value) {
- CHECK(query_.AddFilter(name, base::StringValue(cpp_value)));
+ CHECK(query_.AddFilter(name, base::Value(cpp_value)));
}
#endif

Powered by Google App Engine
This is Rietveld 408576698