Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/declarative_webrequest/webrequest_condition_att ribute.h" 5 #include "extensions/browser/api/declarative_webrequest/webrequest_condition_att ribute.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
11 11
12 #include "base/files/file_path.h" 12 #include "base/files/file_path.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/message_loop/message_loop.h" 15 #include "base/message_loop/message_loop.h"
16 #include "base/run_loop.h" 16 #include "base/run_loop.h"
17 #include "base/values.h" 17 #include "base/values.h"
18 #include "content/public/browser/resource_request_info.h" 18 #include "content/public/browser/resource_request_info.h"
19 #include "content/public/common/previews_state.h" 19 #include "content/public/common/previews_state.h"
20 #include "extensions/browser/api/declarative_webrequest/webrequest_condition.h" 20 #include "extensions/browser/api/declarative_webrequest/webrequest_condition.h"
21 #include "extensions/browser/api/declarative_webrequest/webrequest_constants.h" 21 #include "extensions/browser/api/declarative_webrequest/webrequest_constants.h"
22 #include "net/base/request_priority.h" 22 #include "net/base/request_priority.h"
23 #include "net/test/embedded_test_server/embedded_test_server.h" 23 #include "net/test/embedded_test_server/embedded_test_server.h"
24 #include "net/url_request/url_request.h" 24 #include "net/url_request/url_request.h"
25 #include "net/url_request/url_request_test_util.h" 25 #include "net/url_request/url_request_test_util.h"
26 #include "testing/gtest/include/gtest/gtest.h" 26 #include "testing/gtest/include/gtest/gtest.h"
27 27
28 using base::DictionaryValue; 28 using base::DictionaryValue;
29 using base::ListValue; 29 using base::ListValue;
30 using base::StringValue;
31 using base::Value; 30 using base::Value;
32 31
33 namespace extensions { 32 namespace extensions {
34 33
35 namespace keys = declarative_webrequest_constants; 34 namespace keys = declarative_webrequest_constants;
36 35
37 namespace { 36 namespace {
38 const char kUnknownConditionName[] = "unknownType"; 37 const char kUnknownConditionName[] = "unknownType";
39 38
40 base::FilePath TestDataPath(base::StringPiece relative_to_src) { 39 base::FilePath TestDataPath(base::StringPiece relative_to_src) {
41 base::FilePath src_dir; 40 base::FilePath src_dir;
42 CHECK(PathService::Get(base::DIR_SOURCE_ROOT, &src_dir)); 41 CHECK(PathService::Get(base::DIR_SOURCE_ROOT, &src_dir));
43 return src_dir.AppendASCII(relative_to_src); 42 return src_dir.AppendASCII(relative_to_src);
44 } 43 }
45 44
46 TEST(WebRequestConditionAttributeTest, CreateConditionAttribute) { 45 TEST(WebRequestConditionAttributeTest, CreateConditionAttribute) {
47 // Necessary for TestURLRequest. 46 // Necessary for TestURLRequest.
48 base::MessageLoopForIO message_loop; 47 base::MessageLoopForIO message_loop;
49 48
50 std::string error; 49 std::string error;
51 scoped_refptr<const WebRequestConditionAttribute> result; 50 scoped_refptr<const WebRequestConditionAttribute> result;
52 base::StringValue string_value("main_frame"); 51 base::Value string_value("main_frame");
53 base::ListValue resource_types; 52 base::ListValue resource_types;
54 resource_types.AppendString("main_frame"); 53 resource_types.AppendString("main_frame");
55 54
56 // Test wrong condition name passed. 55 // Test wrong condition name passed.
57 error.clear(); 56 error.clear();
58 result = WebRequestConditionAttribute::Create( 57 result = WebRequestConditionAttribute::Create(
59 kUnknownConditionName, &resource_types, &error); 58 kUnknownConditionName, &resource_types, &error);
60 EXPECT_FALSE(error.empty()); 59 EXPECT_FALSE(error.empty());
61 EXPECT_FALSE(result.get()); 60 EXPECT_FALSE(result.get());
62 61
(...skipping 651 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 }; 713 };
715 const size_t kExistingSize[] = { arraysize(kExisting) }; 714 const size_t kExistingSize[] = { arraysize(kExisting) };
716 GetArrayAsVector(kExisting, kExistingSize, 1u, &tests); 715 GetArrayAsVector(kExisting, kExistingSize, 1u, &tests);
717 MatchAndCheck(tests, keys::kExcludeResponseHeadersKey, stage, 716 MatchAndCheck(tests, keys::kExcludeResponseHeadersKey, stage,
718 url_request.get(), &result); 717 url_request.get(), &result);
719 EXPECT_FALSE(result); 718 EXPECT_FALSE(result);
720 } 719 }
721 720
722 } // namespace 721 } // namespace
723 } // namespace extensions 722 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698