Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1951)

Unified Diff: extensions/browser/api/runtime/runtime_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/runtime/runtime_api.cc
diff --git a/extensions/browser/api/runtime/runtime_api.cc b/extensions/browser/api/runtime/runtime_api.cc
index f5644c4bafc3488e96d23599f71a274b65e74d76..bb4a1f742c4389cb6e9ee79f90ec5f8dcfa71ddb 100644
--- a/extensions/browser/api/runtime/runtime_api.cc
+++ b/extensions/browser/api/runtime/runtime_api.cc
@@ -155,8 +155,8 @@ void DispatchOnStartupEventImpl(BrowserContext* browser_context,
void SetUninstallURL(ExtensionPrefs* prefs,
const std::string& extension_id,
const std::string& url_string) {
- prefs->UpdateExtensionPref(
- extension_id, kUninstallUrl, new base::StringValue(url_string));
+ prefs->UpdateExtensionPref(extension_id, kUninstallUrl,
+ new base::Value(url_string));
}
std::string GetUninstallURL(ExtensionPrefs* prefs,
@@ -701,11 +701,11 @@ void RuntimeRequestUpdateCheckFunction::CheckComplete(
if (result.success) {
std::unique_ptr<base::DictionaryValue> details(new base::DictionaryValue);
details->SetString("version", result.version);
- Respond(TwoArguments(base::MakeUnique<base::StringValue>(result.response),
+ Respond(TwoArguments(base::MakeUnique<base::Value>(result.response),
std::move(details)));
} else {
// HMM(kalman): Why does !success not imply Error()?
- Respond(OneArgument(base::MakeUnique<base::StringValue>(result.response)));
+ Respond(OneArgument(base::MakeUnique<base::Value>(result.response)));
}
}

Powered by Google App Engine
This is Rietveld 408576698