components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc ('k') | components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

diff --git a/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc b/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

index 21ecc437b82959ff877afce578241ce0518b76f6..e891c3f9e39d03c49e8cf4ba3ed80bed1c33fd91 100644

--- a/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

+++ b/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

@@ -88,11 +88,11 @@ class ComponentCloudPolicyStoreTest : public testing::Test {

PolicyMap& policy = expected_bundle_.Get(kTestPolicyNS);

policy.Set("Name", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

- base::MakeUnique<base::StringValue>("disabled"), nullptr);

+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>("disabled"),

+ nullptr);

policy.Set("Second", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

- base::MakeUnique<base::StringValue>("maybe"), nullptr);

+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>("maybe"),

+ nullptr);

}

void SetUp() override {