extensions/browser/api/cast_channel/cast_message_util.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_message_util.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/cast_message_util.cc

diff --git a/extensions/browser/api/cast_channel/cast_message_util.cc b/extensions/browser/api/cast_channel/cast_message_util.cc

index 7cdf1c5aca13ddcc73e2dcaef362c68c82827eb2..5d4e9ff834c52e80ed26c2e31991bcbd8f1595e6 100644

--- a/extensions/browser/api/cast_channel/cast_message_util.cc

+++ b/extensions/browser/api/cast_channel/cast_message_util.cc

@@ -81,7 +81,7 @@ bool CastMessageToMessageInfo(const CastMessage& message_proto,

switch (message_proto.payload_type()) {

case CastMessage_PayloadType_STRING:

if (message_proto.has_payload_utf8())

- value.reset(new base::StringValue(message_proto.payload_utf8()));

+ value.reset(new base::Value(message_proto.payload_utf8()));

break;

case CastMessage_PayloadType_BINARY:

if (message_proto.has_payload_binary())