chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc b/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc

index 4e74d7f32451bd60fdd51245e3ff4300df78bc02..480c624deff25aa38d16ecf16fd45e39f0c31e95 100644

--- a/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc

@@ -180,7 +180,7 @@ void KioskAppMenuHandler::HandleCheckKioskAppLaunchError(

bool new_kiosk_ui = EnableNewKioskUI();

web_ui()->CallJavascriptFunctionUnsafe(

new_kiosk_ui ? kKioskShowErrorNewAPI : kKioskShowErrorOldAPI,

- base::StringValue(error_message));

+ base::Value(error_message));

}

void KioskAppMenuHandler::OnKioskAppsSettingsChanged() {