components/sync/syncable/syncable_id.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/syncable/syncable_id.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/syncable/syncable_id.cc

diff --git a/components/sync/syncable/syncable_id.cc b/components/sync/syncable/syncable_id.cc

index 420ad3877bb990969d533c32311f9e8f9d610b52..24d8dfdbde821416605a2006f3523e292456550e 100644

--- a/components/sync/syncable/syncable_id.cc

+++ b/components/sync/syncable/syncable_id.cc

@@ -18,8 +18,8 @@ ostream& operator<<(ostream& out, const Id& id) {

return out;

}

-base::StringValue* Id::ToValue() const {

- return new base::StringValue(s_);

+base::Value* Id::ToValue() const {

+ return new base::Value(s_);

}

string Id::GetServerId() const {