components/proximity_auth/webui/proximity_auth_webui_handler.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/webui/proximity_auth_webui_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/proximity_auth/webui/proximity_auth_webui_handler.cc

diff --git a/components/proximity_auth/webui/proximity_auth_webui_handler.cc b/components/proximity_auth/webui/proximity_auth_webui_handler.cc

index 834d8af0dfe4cbf857d16180b31ffa86418010dd..943a485dbb687095f8c405403111058c70f3c9a8 100644

--- a/components/proximity_auth/webui/proximity_auth_webui_handler.cc

+++ b/components/proximity_auth/webui/proximity_auth_webui_handler.cc

@@ -368,7 +368,7 @@ void ProximityAuthWebUIHandler::ToggleConnection(const base::ListValue* args) {

void ProximityAuthWebUIHandler::OnCryptAuthClientError(

const std::string& error_message) {

PA_LOG(WARNING) << "CryptAuth request failed: " << error_message;

- base::StringValue error_string(error_message);

+ base::Value error_string(error_message);

web_ui()->CallJavascriptFunctionUnsafe("CryptAuthInterface.onError",

error_string);

}