Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7984)

Unified Diff: chrome/test/base/web_ui_browser_test.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/javascript_browser_test.cc ('k') | chrome/test/base/web_ui_browser_test_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/web_ui_browser_test.cc
diff --git a/chrome/test/base/web_ui_browser_test.cc b/chrome/test/base/web_ui_browser_test.cc
index 4c8d5bc7c8ad02b2d21baf452880de543058013c..fd4e69d5d26ae9b355ce2530e6fc3bd03d460423 100644
--- a/chrome/test/base/web_ui_browser_test.cc
+++ b/chrome/test/base/web_ui_browser_test.cc
@@ -126,8 +126,8 @@ bool WebUIBrowserTest::RunJavascriptTestF(bool is_async,
const std::string& test_fixture,
const std::string& test_name) {
ConstValueVector args;
- args.push_back(new base::StringValue(test_fixture));
- args.push_back(new base::StringValue(test_name));
+ args.push_back(new base::Value(test_fixture));
+ args.push_back(new base::Value(test_name));
if (is_async)
return RunJavascriptAsyncTest("RUN_TEST_F", args);
@@ -207,8 +207,8 @@ void WebUIBrowserTest::PreLoadJavascriptLibraries(
RenderViewHost* preload_host) {
ASSERT_FALSE(libraries_preloaded_);
ConstValueVector args;
- args.push_back(new base::StringValue(preload_test_fixture));
- args.push_back(new base::StringValue(preload_test_name));
+ args.push_back(new base::Value(preload_test_fixture));
+ args.push_back(new base::Value(preload_test_name));
RunJavascriptUsingHandler(
"preloadJavascriptLibraries", args, false, false, preload_host);
libraries_preloaded_ = true;
« no previous file with comments | « chrome/test/base/javascript_browser_test.cc ('k') | chrome/test/base/web_ui_browser_test_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698