chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc ('k') | chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

index a3b40642e23d37dd18909bec20aa073d97f80d38..71649982225399cc1f736d7f573f487c8f6cae6f 100644

--- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

+++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

@@ -81,7 +81,7 @@ CloudPrintPrivateGetHostNameFunction::~CloudPrintPrivateGetHostNameFunction() {

}

bool CloudPrintPrivateGetHostNameFunction::RunAsync() {

- SetResult(base::MakeUnique<base::StringValue>(

+ SetResult(base::MakeUnique<base::Value>(

CloudPrintTestsDelegate::Get()

? CloudPrintTestsDelegate::Get()->GetHostName()

: net::GetHostName()));

@@ -129,7 +129,7 @@ CloudPrintPrivateGetClientIdFunction::~CloudPrintPrivateGetClientIdFunction() {

}

bool CloudPrintPrivateGetClientIdFunction::RunAsync() {

- SetResult(base::MakeUnique<base::StringValue>(

+ SetResult(base::MakeUnique<base::Value>(

CloudPrintTestsDelegate::Get()

? CloudPrintTestsDelegate::Get()->GetClientId()

: google_apis::GetOAuth2ClientID(google_apis::CLIENT_CLOUD_PRINT)));