chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/options/network_property_ui_data_unittest.cc ('k') | chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

diff --git a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

index 3d9977d635a1d283056997f6f3f4cbb47d2b6775..29b91ffb7be7255fee5d61f82100c73c5a2433b0 100644

--- a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

+++ b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

@@ -62,7 +62,7 @@ bool IsOwnerInTests(const std::string& user_id) {

const base::Value* value = CrosSettings::Get()->GetPref(kDeviceOwner);

if (!value || value->GetType() != base::Value::Type::STRING)

return false;

- return static_cast<const base::StringValue*>(value)->GetString() == user_id;

+ return static_cast<const base::Value*>(value)->GetString() == user_id;

}

void LoadPrivateKeyByPublicKey(