Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: tools/json_schema_compiler/test/crossref_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/crossref_unittest.cc
diff --git a/tools/json_schema_compiler/test/crossref_unittest.cc b/tools/json_schema_compiler/test/crossref_unittest.cc
index 75406ea13efa3eff191aad5726376c784ea31d5f..21e52aa3739825c59bd7023138e36ae944e61b5f 100644
--- a/tools/json_schema_compiler/test/crossref_unittest.cc
+++ b/tools/json_schema_compiler/test/crossref_unittest.cc
@@ -18,7 +18,7 @@ std::unique_ptr<base::DictionaryValue> CreateTestTypeValue() {
std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
value->Set("number", new base::Value(1.1));
value->Set("integer", new base::Value(4));
- value->Set("string", new base::StringValue("bling"));
+ value->Set("string", new base::Value("bling"));
value->Set("boolean", new base::Value(true));
return value;
}
@@ -28,8 +28,8 @@ std::unique_ptr<base::DictionaryValue> CreateTestTypeValue() {
TEST(JsonSchemaCompilerCrossrefTest, CrossrefTypePopulateAndToValue) {
base::DictionaryValue crossref_orig;
crossref_orig.Set("testType", CreateTestTypeValue().release());
- crossref_orig.Set("testEnumRequired", new base::StringValue("one"));
- crossref_orig.Set("testEnumOptional", new base::StringValue("two"));
+ crossref_orig.Set("testEnumRequired", new base::Value("one"));
+ crossref_orig.Set("testEnumOptional", new base::Value("two"));
// Test Populate of the value --> compiled type.
crossref::CrossrefType crossref_type;
@@ -115,7 +115,7 @@ TEST(JsonSchemaCompilerCrossrefTest, TestTypeInObjectParamsCreate) {
std::unique_ptr<base::ListValue> params_value(new base::ListValue());
std::unique_ptr<base::DictionaryValue> param_object_value(
new base::DictionaryValue());
- param_object_value->Set("testType", new base::StringValue("invalid"));
+ param_object_value->Set("testType", new base::Value("invalid"));
param_object_value->Set("boolean", new base::Value(true));
params_value->Append(std::move(param_object_value));
std::unique_ptr<crossref::TestTypeInObject::Params> params(
« no previous file with comments | « tools/json_schema_compiler/test/choices_unittest.cc ('k') | tools/json_schema_compiler/test/enums_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698