Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index 6973ebb01aa8d128c139d7f54c07482d9f047922..e1277745894078404c981a4d4b0b1577050a4b8b 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -1487,16 +1487,15 @@ void WebViewGuest::RequestNewWindowPermission(WindowOpenDisposition disposition,
request_info.SetInteger(webview::kInitialHeight, initial_bounds.height());
request_info.SetInteger(webview::kInitialWidth, initial_bounds.width());
request_info.Set(webview::kTargetURL,
- new base::StringValue(new_window_info.url.spec()));
- request_info.Set(webview::kName, new base::StringValue(new_window_info.name));
+ new base::Value(new_window_info.url.spec()));
+ request_info.Set(webview::kName, new base::Value(new_window_info.name));
request_info.SetInteger(webview::kWindowID, guest->guest_instance_id());
// We pass in partition info so that window-s created through newwindow
// API can use it to set their partition attribute.
request_info.Set(webview::kStoragePartitionId,
- new base::StringValue(storage_partition_id));
- request_info.Set(
- webview::kWindowOpenDisposition,
- new base::StringValue(WindowOpenDispositionToString(disposition)));
+ new base::Value(storage_partition_id));
+ request_info.Set(webview::kWindowOpenDisposition,
+ new base::Value(WindowOpenDispositionToString(disposition)));
web_view_permission_helper_->
RequestPermission(WEB_VIEW_PERMISSION_TYPE_NEW_WINDOW,

Powered by Google App Engine
This is Rietveld 408576698