chrome/browser/ui/webui/inspect_ui.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/inspect_ui.cc

diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc

index fdebd22effbc78bc4256e203e535e3182be49249..287e230dc392f910fa8f5e5eb9a5670f3774355a 100644

--- a/chrome/browser/ui/webui/inspect_ui.cc

+++ b/chrome/browser/ui/webui/inspect_ui.cc

@@ -607,8 +607,8 @@ scoped_refptr<content::DevToolsAgentHost> InspectUI::FindTarget(

void InspectUI::PopulateTargets(const std::string& source,

const base::ListValue& targets) {

- web_ui()->CallJavascriptFunctionUnsafe("populateTargets",

- base::StringValue(source), targets);

+ web_ui()->CallJavascriptFunctionUnsafe("populateTargets", base::Value(source),

+ targets);

}

void InspectUI::PopulateAdditionalTargets(const base::ListValue& targets) {