Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/configuration_policy_pref_store_unittest.cc
diff --git a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
index 13513e5aa07a36a17e583326fa59c71c16583de9..7092fa2708d48861ddbb82cf5c7787442584ae88 100644
--- a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
+++ b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
@@ -87,13 +87,12 @@ TEST_F(ConfigurationPolicyPrefStoreStringTest, SetValue) {
PolicyMap policy;
policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>("http://chromium.org"),
- nullptr);
+ base::MakeUnique<base::Value>("http://chromium.org"), nullptr);
UpdateProviderPolicy(policy);
const base::Value* value = NULL;
EXPECT_TRUE(store_->GetValue(kTestPref, &value));
ASSERT_TRUE(value);
- EXPECT_TRUE(base::StringValue("http://chromium.org").Equals(value));
+ EXPECT_TRUE(base::Value("http://chromium.org").Equals(value));
}
// Test cases for boolean-valued policy settings.
@@ -186,12 +185,11 @@ TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Refresh) {
PolicyMap policy;
policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>("http://www.chromium.org"),
- nullptr);
+ base::MakeUnique<base::Value>("http://www.chromium.org"), nullptr);
UpdateProviderPolicy(policy);
observer_.VerifyAndResetChangedKey(kTestPref);
EXPECT_TRUE(store_->GetValue(kTestPref, &value));
- EXPECT_TRUE(base::StringValue("http://www.chromium.org").Equals(value));
+ EXPECT_TRUE(base::Value("http://www.chromium.org").Equals(value));
UpdateProviderPolicy(policy);
EXPECT_TRUE(observer_.changed_keys.empty());

Powered by Google App Engine
This is Rietveld 408576698