extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_request/upload_data_presenter_unittest.cc ('k') | extensions/browser/event_listener_map_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc

diff --git a/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc b/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc

index f1526d183a30b53177da0b6a9cd00a1095f590bb..fc4ad9ea54135f79c0be74f83c2b3529fc9d2369 100644

--- a/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc

+++ b/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc

@@ -205,7 +205,7 @@ void WebcamPrivateOpenSerialWebcamFunction::OnOpenWebcam(

const std::string& webcam_id,

bool success) {

if (success) {

- SetResult(base::MakeUnique<base::StringValue>(webcam_id));

+ SetResult(base::MakeUnique<base::Value>(webcam_id));

SendResponse(true);

} else {

SetError(kOpenSerialWebcamError);