chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_app_identifier.cc ('k') | chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc

index c78892bcf9cb614f5bbf222ceeb7bcc1c960822e..c5141ebb20107ee626d5d1f3dc54012e34266182 100644

--- a/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc

@@ -99,8 +99,8 @@ void ExtensionTestingProfile::AddExtension(std::string extension_id,

extension_service_->AddExtension(extension.get());

extension_prefs_->UpdateExtensionPref(

- extension_id, "install_time", new base::StringValue(base::Int64ToString(

- install_time.ToInternalValue())));

+ extension_id, "install_time",

+ new base::Value(base::Int64ToString(install_time.ToInternalValue())));

extension_prefs_->UpdateExtensionPref(extension_id, "state",

new base::Value(state_value));

}