Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Unified Diff: chrome/browser/notifications/notifier_state_tracker.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notifier_state_tracker.cc
diff --git a/chrome/browser/notifications/notifier_state_tracker.cc b/chrome/browser/notifications/notifier_state_tracker.cc
index 6f094080a860a38988d200854d8ee8d89d9d87f3..a7d2a92357d89ac62d474a3a0661b9fac24c7764 100644
--- a/chrome/browser/notifications/notifier_state_tracker.cc
+++ b/chrome/browser/notifications/notifier_state_tracker.cc
@@ -123,12 +123,12 @@ void NotifierStateTracker::SetNotifierEnabled(
bool add_new_item = false;
const char* pref_name = NULL;
- std::unique_ptr<base::StringValue> id;
+ std::unique_ptr<base::Value> id;
switch (notifier_id.type) {
case NotifierId::APPLICATION:
pref_name = prefs::kMessageCenterDisabledExtensionIds;
add_new_item = !enabled;
- id.reset(new base::StringValue(notifier_id.id));
+ id.reset(new base::Value(notifier_id.id));
#if BUILDFLAG(ENABLE_EXTENSIONS)
FirePermissionLevelChangedEvent(notifier_id, enabled);
#endif
@@ -137,7 +137,7 @@ void NotifierStateTracker::SetNotifierEnabled(
#if defined(OS_CHROMEOS)
pref_name = prefs::kMessageCenterDisabledSystemComponentIds;
add_new_item = !enabled;
- id.reset(new base::StringValue(notifier_id.id));
+ id.reset(new base::Value(notifier_id.id));
#else
return;
#endif
« no previous file with comments | « chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc ('k') | chrome/browser/policy/cloud/cloud_policy_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698