Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: base/test/values_test_util.h

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/json/json_writer_unittest.cc ('k') | base/test/values_test_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TEST_VALUES_TEST_UTIL_H_ 5 #ifndef BASE_TEST_VALUES_TEST_UTIL_H_
6 #define BASE_TEST_VALUES_TEST_UTIL_H_ 6 #define BASE_TEST_VALUES_TEST_UTIL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
11 #include "base/strings/string_piece.h" 11 #include "base/strings/string_piece.h"
12 12
13 namespace base { 13 namespace base {
14 class DictionaryValue; 14 class DictionaryValue;
15 class ListValue; 15 class ListValue;
16 class Value; 16 class Value;
17 using StringValue = Value;
18 17
19 // All the functions below expect that the value for the given key in 18 // All the functions below expect that the value for the given key in
20 // the given dictionary equals the given expected value. 19 // the given dictionary equals the given expected value.
21 20
22 void ExpectDictBooleanValue(bool expected_value, 21 void ExpectDictBooleanValue(bool expected_value,
23 const DictionaryValue& value, 22 const DictionaryValue& value,
24 const std::string& key); 23 const std::string& key);
25 24
26 void ExpectDictDictionaryValue(const DictionaryValue& expected_value, 25 void ExpectDictDictionaryValue(const DictionaryValue& expected_value,
27 const DictionaryValue& value, 26 const DictionaryValue& value,
28 const std::string& key); 27 const std::string& key);
29 28
30 void ExpectDictIntegerValue(int expected_value, 29 void ExpectDictIntegerValue(int expected_value,
31 const DictionaryValue& value, 30 const DictionaryValue& value,
32 const std::string& key); 31 const std::string& key);
33 32
34 void ExpectDictListValue(const ListValue& expected_value, 33 void ExpectDictListValue(const ListValue& expected_value,
35 const DictionaryValue& value, 34 const DictionaryValue& value,
36 const std::string& key); 35 const std::string& key);
37 36
38 void ExpectDictStringValue(const std::string& expected_value, 37 void ExpectDictStringValue(const std::string& expected_value,
39 const DictionaryValue& value, 38 const DictionaryValue& value,
40 const std::string& key); 39 const std::string& key);
41 40
42 // Takes ownership of |actual|. 41 // Takes ownership of |actual|.
43 void ExpectStringValue(const std::string& expected_str, 42 void ExpectStringValue(const std::string& expected_str, Value* actual);
44 StringValue* actual);
45 43
46 namespace test { 44 namespace test {
47 45
48 // Parses |json| as JSON, allowing trailing commas, and returns the 46 // Parses |json| as JSON, allowing trailing commas, and returns the
49 // resulting value. If the json fails to parse, causes an EXPECT 47 // resulting value. If the json fails to parse, causes an EXPECT
50 // failure and returns the Null Value (but never a NULL pointer). 48 // failure and returns the Null Value (but never a NULL pointer).
51 std::unique_ptr<Value> ParseJson(base::StringPiece json); 49 std::unique_ptr<Value> ParseJson(base::StringPiece json);
52 50
53 } // namespace test 51 } // namespace test
54 } // namespace base 52 } // namespace base
55 53
56 #endif // BASE_TEST_VALUES_TEST_UTIL_H_ 54 #endif // BASE_TEST_VALUES_TEST_UTIL_H_
OLDNEW
« no previous file with comments | « base/json/json_writer_unittest.cc ('k') | base/test/values_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698