extensions/browser/api/web_request/upload_data_presenter_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/upload_data_presenter_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_request/upload_data_presenter.cc ('k') | extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/upload_data_presenter_unittest.cc

diff --git a/extensions/browser/api/web_request/upload_data_presenter_unittest.cc b/extensions/browser/api/web_request/upload_data_presenter_unittest.cc

index 6a2fe4fbea930b93f9070025fa0ee4cbce6b061e..548ad634bbb320117c0824976918442ca81e9962 100644

--- a/extensions/browser/api/web_request/upload_data_presenter_unittest.cc

+++ b/extensions/browser/api/web_request/upload_data_presenter_unittest.cc

@@ -54,8 +54,7 @@ TEST(WebRequestUploadDataPresenterTest, RawData) {

std::unique_ptr<base::BinaryValue> expected_a(

base::BinaryValue::CreateWithCopiedBuffer(block1, block1_size));

ASSERT_TRUE(expected_a.get() != NULL);

- std::unique_ptr<base::StringValue> expected_b(

- new base::StringValue(kFilename));

+ std::unique_ptr<base::Value> expected_b(new base::Value(kFilename));

ASSERT_TRUE(expected_b.get() != NULL);

std::unique_ptr<base::BinaryValue> expected_c(

base::BinaryValue::CreateWithCopiedBuffer(block2, block2_size));