Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: tools/clang/value_cleanup/tests/list-value-append-original.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/value_cleanup/ListValueRewriter.cpp ('k') | tools/gn/command_desc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/value_cleanup/tests/list-value-append-original.cc
diff --git a/tools/clang/value_cleanup/tests/list-value-append-original.cc b/tools/clang/value_cleanup/tests/list-value-append-original.cc
index 806da661b335e1d66013f484a2d8349aea81ce10..adebcf49561da0257fb0bf89c27659c3adf0054f 100644
--- a/tools/clang/value_cleanup/tests/list-value-append-original.cc
+++ b/tools/clang/value_cleanup/tests/list-value-append-original.cc
@@ -29,7 +29,7 @@ void F() {
list.Append(new base::Value(true));
list.Append(new base::Value(static_cast<unsigned char>(1.0)));
list.Append(new base::Value(double{3}));
- list.Append(new base::StringValue("abc"));
+ list.Append(new base::Value("abc"));
list.Append(ReturnsUniquePtr().release());
Thing thing;
« no previous file with comments | « tools/clang/value_cleanup/ListValueRewriter.cpp ('k') | tools/gn/command_desc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698