Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7140)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.cc b/chrome/browser/ui/webui/media_router/media_router_ui.cc
index 8e8e974063672381b1a29e92462627bebf12a0df..705823e7af5c5a4562b5926438fed6fc7089edb5 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_ui.cc
@@ -533,7 +533,7 @@ bool MediaRouterUI::UserSelectedTabMirroringForCurrentOrigin() const {
const base::ListValue* origins =
Profile::FromWebUI(web_ui())->GetPrefs()->GetList(
prefs::kMediaRouterTabMirroringSources);
- return origins->Find(base::StringValue(GetSerializedInitiatorOrigin())) !=
+ return origins->Find(base::Value(GetSerializedInitiatorOrigin())) !=
origins->end();
}
@@ -543,12 +543,11 @@ void MediaRouterUI::RecordCastModeSelection(MediaCastMode cast_mode) {
switch (cast_mode) {
case MediaCastMode::DEFAULT:
- update->Remove(base::StringValue(GetSerializedInitiatorOrigin()),
- nullptr);
+ update->Remove(base::Value(GetSerializedInitiatorOrigin()), nullptr);
break;
case MediaCastMode::TAB_MIRROR:
update->AppendIfNotPresent(
- base::MakeUnique<base::StringValue>(GetSerializedInitiatorOrigin()));
+ base::MakeUnique<base::Value>(GetSerializedInitiatorOrigin()));
break;
case MediaCastMode::DESKTOP_MIRROR:
// Desktop mirroring isn't domain-specific, so we don't record the

Powered by Google App Engine
This is Rietveld 408576698