Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: ipc/ipc_message_utils.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_message_unittest.cc ('k') | ipc/ipc_message_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_utils.cc
diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc
index 328e804a980cd3115d5186d324815533419d0d67..bf8daa5d9741189df50bdac48f7b39cf5744e5a2 100644
--- a/ipc/ipc_message_utils.cc
+++ b/ipc/ipc_message_utils.cc
@@ -96,7 +96,7 @@ void GetValueSize(base::PickleSizer* sizer,
sizer->AddDouble();
break;
case base::Value::Type::STRING: {
- const base::StringValue* result;
+ const base::Value* result;
value->GetAsString(&result);
if (value->GetAsString(&result)) {
DCHECK(result);
@@ -289,7 +289,7 @@ bool ReadValue(const base::Pickle* m,
std::string val;
if (!ReadParam(m, iter, &val))
return false;
- *value = new base::StringValue(val);
+ *value = new base::Value(val);
break;
}
case base::Value::Type::BINARY: {
« no previous file with comments | « ipc/ipc_message_unittest.cc ('k') | ipc/ipc_message_utils_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698