mojo/common/common_custom_types_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/common_custom_types_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/common/common_custom_types_unittest.cc

diff --git a/mojo/common/common_custom_types_unittest.cc b/mojo/common/common_custom_types_unittest.cc

index fe61a35cdcf47defb636db171d820ca007930d04..e3571d9d86cf65e54718868e089bf976101d4929 100644

--- a/mojo/common/common_custom_types_unittest.cc

+++ b/mojo/common/common_custom_types_unittest.cc

@@ -290,7 +290,7 @@ TEST_F(CommonCustomTypesTest, Value) {

ASSERT_TRUE(ptr->BounceValue(input->CreateDeepCopy(), &output));

EXPECT_TRUE(base::Value::Equals(input.get(), output.get()));

- input = base::MakeUnique<base::StringValue>("test string");

+ input = base::MakeUnique<base::Value>("test string");

ASSERT_TRUE(ptr->BounceValue(input->CreateDeepCopy(), &output));

EXPECT_TRUE(base::Value::Equals(input.get(), output.get()));

« no previous file with comments | « ipc/ipc_message_utils_unittest.cc ('k') | mojo/common/values_struct_traits.cc » ('j') | no next file with comments »