chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

diff --git a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc b/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

index 8070f70474065e1cf26a5eaa0c0b0a6dc48c085e..56093d1f977c84af5611bdc270324eb99f4cfeab 100644

--- a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

+++ b/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc

@@ -137,13 +137,11 @@ void MediaDevicesSelectionHandler::UpdateDevicesMenu(

if (!devices.empty() && default_id.empty())

default_id = devices[0].id;

- base::StringValue default_value(default_id);

- base::StringValue type_value(device_type);

+ base::Value default_value(default_id);

+ base::Value type_value(device_type);

CallJavascriptFunction("cr.webUIListenerCallback",

- base::StringValue("updateDevicesMenu"),

- type_value,

- device_list,

- default_value);

+ base::Value("updateDevicesMenu"), type_value,

+ device_list, default_value);

}

std::string MediaDevicesSelectionHandler::GetDeviceDisplayName(