Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/gn/command_desc.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/value_cleanup/tests/list-value-append-original.cc ('k') | tools/gn/desc_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_desc.cc
diff --git a/tools/gn/command_desc.cc b/tools/gn/command_desc.cc
index 1de9fbb12da098508eb2898209a7f4f4882e3855..8e4ebd7e7c0bbc73679ebcce40cca7154751c26b 100644
--- a/tools/gn/command_desc.cc
+++ b/tools/gn/command_desc.cc
@@ -85,7 +85,7 @@ void VisibilityHandler(const std::string& name, const base::Value* value) {
const base::ListValue* list;
if (value->GetAsList(&list)) {
if (list->empty()) {
- base::StringValue str("(no visibility)");
+ base::Value str("(no visibility)");
DefaultHandler(name, &str);
} else {
DefaultHandler(name, value);
@@ -97,7 +97,7 @@ void PublicHandler(const std::string& name, const base::Value* value) {
std::string p;
if (value->GetAsString(&p)) {
if (p == "*") {
- base::StringValue str("[All headers listed in the sources are public.]");
+ base::Value str("[All headers listed in the sources are public.]");
DefaultHandler(name, &str);
return;
}
« no previous file with comments | « tools/clang/value_cleanup/tests/list-value-append-original.cc ('k') | tools/gn/desc_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698