base/values.h - Issue 2664753002: Remove base::StringValue - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(2656)

My Issues | Starred Open | Closed | All

Unified Diff: base/values.h

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « base/value_conversions.cc ('k') | base/values.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/values.h

diff --git a/base/values.h b/base/values.h

index a95786878b2eaaba6e76cf2e6b0ccd6a9dc811b7..9610c2816e9e2ab6be6d5d67baf8be37d87abbc5 100644

--- a/base/values.h

+++ b/base/values.h

@@ -39,7 +39,6 @@ namespace base {

class DictionaryValue;

class ListValue;

class Value;

-using StringValue = Value;

using BinaryValue = Value;

// The Value class is the base class for Values. A Value can be instantiated

@@ -143,7 +142,7 @@ class BASE_EXPORT Value {

bool GetAsDouble(double* out_value) const;

bool GetAsString(std::string* out_value) const;

bool GetAsString(string16* out_value) const;

- bool GetAsString(const StringValue** out_value) const;

+ bool GetAsString(const Value** out_value) const;

bool GetAsString(StringPiece* out_value) const;

bool GetAsBinary(const BinaryValue** out_value) const;

// ListValue::From is the equivalent for std::unique_ptr conversions.

« no previous file with comments | « base/value_conversions.cc ('k') | base/values.cc » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698