Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h" 5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 96
97 void WebUIBidiCheckerBrowserTest::SetUpInProcessBrowserTestFixture() { 97 void WebUIBidiCheckerBrowserTest::SetUpInProcessBrowserTestFixture() {
98 WebUIBrowserTest::SetUpInProcessBrowserTestFixture(); 98 WebUIBrowserTest::SetUpInProcessBrowserTestFixture();
99 WebUIBrowserTest::AddLibrary(WebUIBidiCheckerLibraryJSPath()); 99 WebUIBrowserTest::AddLibrary(WebUIBidiCheckerLibraryJSPath());
100 WebUIBrowserTest::AddLibrary(base::FilePath(kBidiCheckerTestsJS)); 100 WebUIBrowserTest::AddLibrary(base::FilePath(kBidiCheckerTestsJS));
101 } 101 }
102 102
103 void WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage( 103 void WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(
104 const std::string& page_url, bool is_rtl) { 104 const std::string& page_url, bool is_rtl) {
105 ui_test_utils::NavigateToURL(browser(), GURL(page_url)); 105 ui_test_utils::NavigateToURL(browser(), GURL(page_url));
106 ASSERT_TRUE(RunJavascriptTest("runBidiChecker", 106 ASSERT_TRUE(RunJavascriptTest("runBidiChecker", new base::Value(page_url),
107 new base::StringValue(page_url),
108 new base::Value(is_rtl))); 107 new base::Value(is_rtl)));
109 } 108 }
110 109
111 void DISABLED_WebUIBidiCheckerBrowserTestLTR::RunBidiCheckerOnPage( 110 void DISABLED_WebUIBidiCheckerBrowserTestLTR::RunBidiCheckerOnPage(
112 const std::string& page_url) { 111 const std::string& page_url) {
113 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(page_url, false); 112 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(page_url, false);
114 } 113 }
115 114
116 void DISABLED_WebUIBidiCheckerBrowserTestRTL::RunBidiCheckerOnPage( 115 void DISABLED_WebUIBidiCheckerBrowserTestRTL::RunBidiCheckerOnPage(
117 const std::string& page_url) { 116 const std::string& page_url) {
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
731 730
732 IN_PROC_BROWSER_TEST_F(DISABLED_WebUIBidiCheckerBrowserTestLTR, 731 IN_PROC_BROWSER_TEST_F(DISABLED_WebUIBidiCheckerBrowserTestLTR,
733 TestHistoryFrame) { 732 TestHistoryFrame) {
734 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL); 733 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
735 } 734 }
736 735
737 IN_PROC_BROWSER_TEST_F(DISABLED_WebUIBidiCheckerBrowserTestRTL, 736 IN_PROC_BROWSER_TEST_F(DISABLED_WebUIBidiCheckerBrowserTestRTL,
738 TestHistoryFrame) { 737 TestHistoryFrame) {
739 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL); 738 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
740 } 739 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/app_launcher_login_handler.cc ('k') | chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698