Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc
diff --git a/chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc b/chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc
index d0f803701e5a8a9c7199dbaf0a0bdf469eaef808..9ff957d40f6060658150103983a913c6beae3a8a 100644
--- a/chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc
+++ b/chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc
@@ -54,7 +54,7 @@ class SupervisedUserCreateConfirmHandler::ProfileUpdateObserver
// affected profile and update or close as needed.
void OnProfileWasRemoved(const base::FilePath& profile_path,
const base::string16& profile_name) override {
- std::unique_ptr<base::StringValue> profile_path_value(
+ std::unique_ptr<base::Value> profile_path_value(
base::CreateFilePathValue(profile_path));
create_confirm_handler_->web_ui()->CallJavascriptFunctionUnsafe(
"SupervisedUserCreateConfirmOverlay.onDeletedProfile",
@@ -68,11 +68,11 @@ class SupervisedUserCreateConfirmHandler::ProfileUpdateObserver
GetProfileAttributesWithPath(profile_path, &entry))
return;
base::string16 new_profile_name = entry->GetName();
- std::unique_ptr<base::StringValue> profile_path_value(
+ std::unique_ptr<base::Value> profile_path_value(
base::CreateFilePathValue(profile_path));
create_confirm_handler_->web_ui()->CallJavascriptFunctionUnsafe(
"SupervisedUserCreateConfirmOverlay.onUpdatedProfileName",
- *profile_path_value, base::StringValue(new_profile_name));
+ *profile_path_value, base::Value(new_profile_name));
}
// Weak.

Powered by Google App Engine
This is Rietveld 408576698